- Notifications
You must be signed in to change notification settings - Fork928
feat(coderd): add enabled experiments to telemetry#12656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
| require.Equal(t, "aws_marketplace", deployment.InstallSource) | ||
| } | ||
| func collectSnapshot(t *testing.T, db database.Store) (*telemetry.Deployment, *telemetry.Snapshot) { | ||
| func collectSnapshot(t *testing.T, db database.Store, addOptionsFn func(opts telemetry.Options) telemetry.Options) (*telemetry.Deployment, *telemetry.Snapshot) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
suggestion, nonblocking: if you makeaddOptionsFn variadic you can avoid the need for changes on line 88 and 113
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's an interesting idea, but I think it'd change the semantics a bit.
Relates to#12070
This is PR 1 of 2 to complete this feature.
I'll be preparing a separate PR to add the receiver on the telemetry server.