Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: support adjusting child proc oom scores#12655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sreya merged 10 commits intomainfromjon/procprio
Apr 3, 2024
Merged

Conversation

sreya
Copy link
Collaborator

@sreyasreya commentedMar 19, 2024
edited
Loading

  • Adds support for modifying child processoom_score_adj values. The logic for the child's score is:
    • If agent score < 0 then 0
    • If 0 <= agent score < 998 then 998
    • If agent score >= 998 then 1000
  • Reduces potential for log spam when we're not permitted to adjust a process's niceness or oom_score
  • Adds aCODER_PRO_OOM_SCORE for specifying an explicit value for child oom scores

It's still the responsibility of the template admin to run the agent with a customer oom score since it's awkward for us to set it ourselves (we needcap_sys_resourceand it needs to be set on the binary since we can't elevate or own privileges if we're ever run as non-root)...if people want this we can eventually support it.

@deansheather I didn't go with the solution we talked about since I was encountering some inconsistencies when adding acoder agent exec command...I think it's due to needing to lock the OS thread we're running on but I had to do some jank to make it work so let's hold off until this solution isn't sufficient.

@sreyasreya changed the titlefix: adjust process oom_score_adj to 0feat: support adjusting child proc oom scoresMar 21, 2024
@sreyasreya marked this pull request as ready for reviewMarch 21, 2024 00:25
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelMar 30, 2024
@sreyasreya removed the staleThis issue is like stale bread. labelApr 2, 2024
@sreyasreya requested a review fromdeansheatherApril 2, 2024 22:52
@sreyasreya merged commit426e9f2 intomainApr 3, 2024
@sreyasreya deleted the jon/procprio branchApril 3, 2024 14:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@sreyasreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sreya@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp