- Notifications
You must be signed in to change notification settings - Fork928
docs: use scale testing utility#12643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
docs/admin/scale.md Outdated
| Depending on the traffic projections, operators can deploy different sample | ||
| clusters to perform scale tests. It is recommended to learn how to operate the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The workspace template doesn't control the cluster size; this is up to operators to control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Rephrased the paragraph 👍
| node_affinity { | ||
| required_during_scheduling_ignored_during_execution { | ||
| node_selector_term { | ||
| match_expressions { | ||
| key = "cloud.google.com/gke-nodepool" | ||
| operator = "In" | ||
| values = ["big-workspaces", "big-workspaces2"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We might want to make this a parameter instead so it's easier to control the node affinity key/value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I verified this, and it looks like we need to add the parameter toscaletest-runner, and then modify thescaletest create-workspaces to accept the parameter. It sounds to me more like a follow-up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
TBH it could just be hard-coded in the template but folks who just use the template as-is are likely going to run into issues. Maybe add a note about having to edit the node affinity to match your environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Alright, I added a template variable and dropped a note in docs.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Related:#12426
Preview:https://github.com/coder/coder/blob/12426-own-scale-tests/docs/admin/scale.md
This PR updates theScaling Coder page with recent changes in scaletest-runner.
Changes:
coder scaletestswitches