NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

fix(examples/lima/coder.yaml): update base image, remove usage of deprecated LIMA_CIDATA#12613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

johnstcn merged 2 commits intomainfromcj/lima-updates

Mar 15, 2024

Merged

fix(examples/lima/coder.yaml): update base image, remove usage of deprecated LIMA_CIDATA#12613

johnstcn merged 2 commits intomainfromcj/lima-updates

Mar 15, 2024

Conversation

Copy link

Member

johnstcn commentedMar 15, 2024•
edited
Loading

Updates base image used by lima config
Removes usage of deprecated LIMA_CIDATA
Names docker template consistently (we were appending $ARCH before)

To kick the tyres:

limactl start  --name=coder examples/lima/coder.yaml

fix(examples/lima/coder.yaml): update base image, remove usage of dep…

4ef4e11

…recated LIMA_CIDATA, name template consistently

johnstcn requested review frommafredri andf0ssel

March 15, 2024 16:10

johnstcn self-assigned this

Mar 15, 2024

johnstcn changed the title~~fix(examples/lima/coder.yaml): update base image, remove usage of deprecated LIMA_CIDATA, name template consistently~~fix(examples/lima/coder.yaml): update base image, remove usage of deprecated LIMA_CIDATA

Mar 15, 2024

make fmt

ec3a6cc

mafredri approved these changes

Mar 15, 2024

View reviewed changes

examples/lima/coder.yaml

		@@ -63,7 +62,7 @@ provision:
		# SSH session around. We don't want users to have to manually delete ~/.lima/$VM/ssh.sock
		# so we're just instead going to modify the perms on the Docker socket.
		# See: https://github.com/lima-vm/lima/issues/528
		chown${LIMA_CIDATA_USER} /var/run/docker.sock
		chown{{.User}} /var/run/docker.sock