Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(cli): show queue position during workspace builds#12606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 6 commits intocoder:mainfromdannykopping:dk/cliq
Mar 18, 2024

Conversation

dannykopping
Copy link
Contributor

@dannykoppingdannykopping commentedMar 15, 2024•
edited
Loading

Fixes#9434

Note for the reviewer:

  • some drive-by refactoring to move regularly-referenced strings to consts
  • added the ability to use a regex match in PTTY output instead of a simple string match because I needed to prove theabsence of any extra text
  • this works for both workspacestop andstart
  • ensuring tests don't run indefinitely (added in4367e65 in response to a review comment)

image

Each time the position in the queue changes, an update will be printed

image

matifali reacted with thumbs up emoji
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
e.t.Helper()

timeout, cancel := context.WithTimeout(context.Background(), testutil.WaitMedium)
defer cancel()

returne.ExpectMatchContext(timeout, str)
returnimpl(timeout, str)
}

// TODO(mafredri): Rename this to ExpectMatch when refactoring.
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@mafredri not really sure what this TODO is about since both this and theExpectMatch functions have lots of usage. Could you elaborate please?

Copy link
Member

@mafredrimafredriMar 15, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Essentially the non-context variant should be marked deprecated. All usage switched to context. Then delete the non-context one and rename this to not have context in the name.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OK, is it because we need to be able to control the deadline?
I think I'll do that in a separate PR.

@dannykoppingdannykopping marked this pull request as ready for reviewMarch 15, 2024 14:06
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍 Some suggestions below.

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice! Feel free to ignore these nit picks. Happy weekend!

@matifali
Copy link
Member

We are now showing queue position in the workspace list page, and also on the CI.
How hard it would be to show the queue size on the/health page for each provisioner.

A nice to have would be to add an expandable table that lists the jobs/workspaces currently in queue for each of them.

@dannykopping
Copy link
ContributorAuthor

We are now showing queue position in the workspace list page, and also on the CI. How hard it would be to show the queue size on the/health page for each provisioner.

A nice to have would be to add an expandable table that lists the jobs/workspaces currently in queue for each of them.

Should be doable, but is out of scope for this issue.
I see you added a new issue#12627 👍 thanks; we'll address it separately.

matifali reacted with thumbs up emoji

@dannykoppingdannykopping merged commit93933d7 intocoder:mainMar 18, 2024
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 18, 2024
@dannykoppingdannykopping deleted the dk/cliq branchMarch 18, 2024 10:05
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri left review comments

@johnstcnjohnstcnjohnstcn approved these changes

@mtojekmtojekmtojek approved these changes

Assignees

@dannykoppingdannykopping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show place in queue in CLI (e.g.coder start [workspace])
5 participants
@dannykopping@matifali@mafredri@johnstcn@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp