Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(support): add client magicsock and agent prometheus metrics to support bundle#12604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 6 commits intomainfromcj/support-agent-extra
Mar 15, 2024

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedMar 15, 2024•
edited
Loading

Part of#12161

  • Refactors agent prometheus handler so we can also serve it on tailnet
  • Adds workspaceagentconn method to retrieve prometheus metrics over tailnet
  • Adds client magicsock HTML and agent prometheus metrics to support bundle

@johnstcnjohnstcn changed the titleCj/support agent extrafeat(support): add client magicsock and prometheus metrics to support bundleMar 15, 2024
@johnstcnjohnstcn changed the titlefeat(support): add client magicsock and prometheus metrics to support bundlefeat(support): add client magicsock and agent prometheus metrics to support bundleMar 15, 2024
@johnstcnjohnstcn marked this pull request as ready for reviewMarch 15, 2024 12:46
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Mostly LGTM, minor stuff.

@@ -382,6 +385,9 @@ func (c *WorkspaceAgentConn) DebugManifest(ctx context.Context) ([]byte, error)
return nil, xerrors.Errorf("do request: %w", err)
}
defer res.Body.Close()
if res.StatusCode != http.StatusOK {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ooh, I thought about this in previous PRs but assumed it was handled byc.apiRequest 😅

johnstcn reacted with thumbs up emoji
johnstcnand others added3 commitsMarch 15, 2024 14:39
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
@johnstcnjohnstcn merged commitb0c4e75 intomainMar 15, 2024
@johnstcnjohnstcn deleted the cj/support-agent-extra branchMarch 15, 2024 15:33
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 15, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@spikecurtisspikecurtisAwaiting requested review from spikecurtis

@mtojekmtojekAwaiting requested review from mtojek

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@johnstcn@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp