- Notifications
You must be signed in to change notification settings - Fork928
chore(site): upgrade msw to 2.0#12597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| // TODO: This test is timing out after upgrade a few Jest dependencies | ||
| // and I was not able to figure out why. When running it specifically, I | ||
| // can see many act warnings that may can help us to find the issue. | ||
| "/usePaginatedQuery.test.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@Parkreiner I may need your help with this 🙏 I created a separated issue to not block this one#12598
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No worries! Happy to take a look tomorrow after Backstage launch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
rather than temporarily ignore the file, can we usetest.failing on the tests in the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh, I didn't realize that was an option. Definitely think we should go with that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For some reason,describe.skip ortest.failure are not working 😢 it just hangs forever
Screen.Recording.2024-03-14.at.14.54.43.mov
Ps: I tried to post a longer video but GH didn't allow me because of the size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
that's annoying... what happens if you add an empty non-skipped test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
it just hangs... I think there is some weird thing happening on this test 🤔
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| @@ -37,7 +37,7 @@ function render< | |||
| * There are a lot of test cases in this file. Scoping mocking to inner describe | |||
| * function calls to limit the cognitive load of maintaining all this stuff | |||
| */ | |||
| describe(usePaginatedQuery.name, () => { | |||
| describe.skip(usePaginatedQuery.name, () => { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: maybe you can just importskip?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let me see if that works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
skip is not exported directly. It needs to be used withdescribe,test, orit but something is preventing this to be working properly. I think Kayla found a similar issues on this PR#12538
Parkreiner left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Big fan of the cleaner API – thanks for handling the upgrade!
I think everything looks good enough to ship, but I did have one comment about a test case possibly relying too much on MSW implementation details
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Closes#11426