- Notifications
You must be signed in to change notification settings - Fork928
feat(examples): add linting to all examples#12595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
d53ceb3 to03ad9d5Compared461d12 tob981cf2Compare| @@ -1,7 +1,7 @@ | |||
| --- | |||
| display_name: Incus System Container with Docker | |||
| description: Develop in an Incus System Container with Docker using incus | |||
| icon: /icon/lxc.svg | |||
| icon:../../../site/static/icon/lxc.svg | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
To be fair, both forms work. But all our otherexamples/templates use this relative form, and it's handy for confirming that the exact path exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yep, +1 for enforced consistency!
Uh oh!
There was an error while loading.Please reload this page.
This PR adds linting and validation improved validation for examples templates and matches the requirements imposed by registry.coder.com.
The improvements caught an additional issue:
Ultimately the icon path was correct (as seen from the dashboard), but all other templates use a relative path so that we can verify the icons existence.
Here's another example after fudging up some more files:
Fixes#12588