Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: handle CLI default organization when none exists in <v2.9.0 coderd#12594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 3 commits intomainfromstevenmasley/set_org_help
Mar 14, 2024

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedMar 14, 2024•
edited
Loading

If the coder cli is talking to an older version of Coderd, theisDefault field will be false.

This can also happen if a user does not belong to the default org.

@EmyrkEmyrk changed the titlechore: 'coder org set' help message was incorrectfix: cli default org when no default org exists (older coderd)Mar 14, 2024
@EmyrkEmyrk changed the titlefix: cli default org when no default org exists (older coderd)fix: handle CLI default organization when none exists in <v2.9.0 coderdMar 14, 2024
@EmyrkEmyrk requested a review fromkylecarbsMarch 14, 2024 14:25
@EmyrkEmyrk requested a review frommafredriMarch 14, 2024 16:20
Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You should add a comment when we can remove this, just so it doesn't live forever.

@Emyrk
Copy link
MemberAuthor

You should add a comment when we can remove this, just so it doesn't live forever.

I thought about it and this can actually occur in the future too. If you create a new user to a single organization, and that org is not the default, this remains helpful.

@EmyrkEmyrk merged commit29c8cf2 intomainMar 14, 2024
@EmyrkEmyrk deleted the stevenmasley/set_org_help branchMarch 14, 2024 20:11
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 14, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@mafredrimafredriAwaiting requested review from mafredri

Assignees

@EmyrkEmyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Emyrk@kylecarbs
[8]ページ先頭
©2009-2025 Movatter.jp