Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: importing api into vscode-coder#12570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 2 commits intomainfromasher/fix-vscode-coder-import
Mar 13, 2024

Conversation

code-asher
Copy link
Member

@code-ashercode-asher commentedMar 12, 2024•
edited
Loading

We import this file in vscode-coder to make use of the API, and eventually the Backstage plugin as well probably.

Likely we want to export an official SDK, but in the meantime we need to make sure we are not importing anything using aliases in this file.

Example of the error we get in vscode-coder:

ERROR in /home/runner/work/vscode-coder/vscode-coder/node_modules/coder/site/src/api/api.ts./node_modules/coder/site/src/api/api.ts 4:22-35[tsl] ERROR in /home/runner/work/vscode-coder/vscode-coder/node_modules/coder/site/src/api/api.ts(4,23)      TS2[30](https://github.com/coder/vscode-coder/actions/runs/8255588769/job/22582395856#step:5:31)7: Cannot find module 'utils/delay' or its corresponding type declarations.ts-loader-default_ab4862433a94faea @ ./src/extension.ts 40:14-47

https://github.com/coder/vscode-coder/actions/runs/8255588769/job/22582395856#step:5:29

@code-ashercode-asherforce-pushed theasher/fix-vscode-coder-import branch from553af86 tod089f1bCompareMarch 12, 2024 21:10
@code-ashercode-asher marked this pull request as ready for reviewMarch 12, 2024 21:10
@code-ashercode-asher requested review froma team andKira-Pilot and removed request fora teamMarch 12, 2024 21:10
@code-asher
Copy link
MemberAuthor

Ping @coder/ts just as a heads up, not sure how many folks know this file is being (ab)used externally.

@aslilac
Copy link
Member

aslilac commentedMar 12, 2024•
edited
Loading

could this be a

/** *@fileoverview This file is imported externally... */

comment instead?

@code-asher
Copy link
MemberAuthor

@fileoverview is a great idea, will add!

aslilac reacted with heart emoji

Not sure if it has to go to the top, but it makes sense to me.
@code-ashercode-asher merged commit0d16df9 intomainMar 13, 2024
@code-ashercode-asher deleted the asher/fix-vscode-coder-import branchMarch 13, 2024 18:05
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 13, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees

@code-ashercode-asher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@code-asher@aslilac@Kira-Pilot
[8]ページ先頭
©2009-2025 Movatter.jp