Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add awsiamrds db auth driver#12566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
f0ssel merged 21 commits intomainfromf0ssel/awsrdsiam
Mar 20, 2024
Merged

feat: add awsiamrds db auth driver#12566

f0ssel merged 21 commits intomainfromf0ssel/awsrdsiam
Mar 20, 2024

Conversation

f0ssel
Copy link
Contributor

@f0sself0ssel commentedMar 12, 2024
edited
Loading

stirby reacted with thumbs up emoji
f0ssel added a commit to coder/serpent that referenced this pull requestMar 18, 2024
My tests are failing over atcoder/coder#12566, enums are failing to marshal correctly, and this patch is what made it work on my branch when it was `clibase`.
@f0sself0ssel marked this pull request as ready for reviewMarch 19, 2024 14:22
@f0sself0ssel requested a review fromcoadlerMarch 19, 2024 14:22
@@ -154,6 +166,7 @@ type DeploymentValues struct {
CacheDir serpent.String `json:"cache_directory,omitempty" typescript:",notnull"`
InMemoryDatabase serpent.Bool `json:"in_memory_database,omitempty" typescript:",notnull"`
PostgresURL serpent.String `json:"pg_connection_url,omitempty" typescript:",notnull"`
PostgresAuth string `json:"pg_auth,omitempty" typescript:",notnull"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is there a specific string format the connection has when connecting via AWS IAM? I think it'd be preferred to check for that over adding a new server option.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just a missing password field, maybe an AWS domain in the URL, but I don't think there's anything that's enough to make an inference.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One thing that might be possible is if we detected the URL scheme and had people setawsiamrds://... instead ofpostgres://, or add a query param? It is unforunate we need a new flag just for aws auth, but it's probable we would exapand this in the future. My only worry is that just detecting it in the connection string would be non-obvious, since I haven't really seen it anywhere else, but to be fair I haven't really done much research.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah I wouldn't wanna change the protocol because that kinda implies it's not speakingpostgres protocol. I think given we may have other auth schemes in the future we need to support, a flag seems fine to me and better than any parsing options I can think of.

@f0sself0ssel changed the titlefeat: add awsrdsiam db auth connectorfeat: add awsrdsiam db auth driverMar 19, 2024
@f0sself0ssel changed the titlefeat: add awsrdsiam db auth driverfeat: add awsiamrds db auth driverMar 19, 2024
@f0sself0ssel merged commit4d9fe05 intomainMar 20, 2024
@f0sself0ssel deleted the f0ssel/awsrdsiam branchMarch 20, 2024 17:14
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 20, 2024
@f0sself0ssel restored the f0ssel/awsrdsiam branchAugust 7, 2024 15:31
@github-actionsgithub-actionsbot deleted the f0ssel/awsrdsiam branchSeptember 20, 2024 00:05
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kylecarbskylecarbskylecarbs left review comments

@coadlercoadlercoadler approved these changes

Assignees

@f0sself0ssel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Direct database authentication with AWS RDS
3 participants
@f0ssel@coadler@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp