- Notifications
You must be signed in to change notification settings - Fork928
fix: hide actions and notifications from deleted workspaces#12563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good! Left a comment, but I think the code is safe to merge as-is
| const isImmutable = | ||
| workspace.latest_build.status === "deleted" || | ||
| workspace.latest_build.status === "deleting"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Quick shout: we do still have logic in theWorkspacesActions component to handle the deletion statuses. I'm not sure if you saw that, but I actually think we should keep them, as a form of double-bookkeeping. Not sure what you think, though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yeah, let's go with that. :) (it probably is helpful to make sure we don't regress in a big way)
Uh oh!
There was an error while loading.Please reload this page.
Closes#12561
Don't bother showing the action buttons et al if the workspace has been deleted