Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Usecliui.WorkspaceBuild to prevent cancel of builds jobs#1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromfixcancel
May 2, 2022

Conversation

kylecarbs
Copy link
Member

Build jobs cannot gracefully terminate because Terraform generally
cannot gracefully terminate.

Build jobs cannot gracefully terminate because Terraform generallycannot gracefully terminate.
@kylecarbskylecarbs self-assigned thisMay 2, 2022
@codecov
Copy link

codecovbot commentedMay 2, 2022•
edited
Loading

Codecov Report

Merging#1255 (96b2539) intomain (4ff5734) willincrease coverage by0.13%.
The diff coverage is33.33%.

@@            Coverage Diff             @@##             main    #1255      +/-   ##==========================================+ Coverage   65.93%   66.06%   +0.13%==========================================  Files         272      275       +3       Lines       17892    17937      +45       Branches      192      214      +22     ==========================================+ Hits        11797    11850      +53+ Misses       4871     4855      -16- Partials     1224     1232       +8
FlagCoverage Δ
unittest-go-macos-latest53.37% <33.33%> (-0.06%)⬇️
unittest-go-postgres-64.96% <33.33%> (+0.12%)⬆️
unittest-go-ubuntu-latest55.65% <33.33%> (+0.08%)⬆️
unittest-go-windows-202252.97% <0.00%> (+0.13%)⬆️
unittest-js70.60% <ø> (+0.63%)⬆️
Impacted FilesCoverage Δ
cli/workspacestart.go19.23% <0.00%> (+5.71%)⬆️
cli/workspacestop.go19.23% <0.00%> (+6.73%)⬆️
cli/server.go58.79% <100.00%> (-0.21%)⬇️
provisionersdk/serve.go35.13% <0.00%> (-8.11%)⬇️
provisionerd/provisionerd.go75.76% <0.00%> (-1.61%)⬇️
peer/channel.go84.97% <0.00%> (-1.16%)⬇️
site/src/theme/palettes.ts100.00% <0.00%> (ø)
site/src/components/Icons/SearchIcon.tsx100.00% <0.00%> (ø)
...ite/src/components/ConfirmDialog/ConfirmDialog.tsx94.11% <0.00%> (ø)
site/src/components/Dialog/Dialog.tsx74.41% <0.00%> (ø)
... and2 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update4ff5734...96b2539. Read thecomment docs.

Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You need to write a ticket to support build cancellation in the future. We can probably support it by exiting terraform, then calling destroy on each ephemeral resource manually.

@kylecarbs
Copy link
MemberAuthor

We do support build cancellation, but it's better for infrastructure folks to rely on Terraform timeouts instead. I'm going to be making significant changes here this week.

@kylecarbskylecarbs merged commita79aa64 intomainMay 2, 2022
@kylecarbskylecarbs deleted the fixcancel branchMay 2, 2022 15:20
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
kylecarbs added a commit that referenced this pull requestJun 10, 2022
Build jobs cannot gracefully terminate because Terraform generallycannot gracefully terminate.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

3 participants
@kylecarbs@deansheather@misskniss
[8]ページ先頭
©2009-2025 Movatter.jp