Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(codersdk): explain format of codersdk.UpdateWorkspaceAutostartRequest.Schedule#12539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 1 commit intomainfromcj/apidoc-schedule
Mar 11, 2024

Conversation

@johnstcn
Copy link
Member

No description provided.

@johnstcnjohnstcn self-assigned thisMar 11, 2024
@johnstcnjohnstcn requested a review fromstirbyMarch 11, 2024 22:33
Copy link
Collaborator

@stirbystirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome, glad we can get this in before 2.9.0.


// UpdateWorkspaceAutostartRequest is a request to update a workspace's autostart schedule.
typeUpdateWorkspaceAutostartRequeststruct {
// Schedule is expected to be of the form `CRON_TZ=<IANA Timezone> <min> <hour> * * <dow>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is there a reason we don't deprecate this field and instead makeCronTimezone the property on the struct?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could definitely do this! Main reason was to document. Will file a follow-up.

@johnstcnjohnstcn merged commitd704ff4 intomainMar 11, 2024
@johnstcnjohnstcn deleted the cj/apidoc-schedule branchMarch 11, 2024 22:50
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 11, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@kylecarbskylecarbskylecarbs left review comments

@stirbystirbystirby approved these changes

@mafredrimafredriAwaiting requested review from mafredri

@mtojekmtojekAwaiting requested review from mtojek

Assignees

@johnstcnjohnstcn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@johnstcn@kylecarbs@stirby

[8]ページ先頭

©2009-2025 Movatter.jp