Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: disable auto-create if external auth requirements aren't met#12538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 15 commits intomainfrompause-auto-mode
Mar 19, 2024

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedMar 11, 2024
edited
Loading

Closes#12491

Basically,mode=auto should be ignored if a required auth provider is missing

bpmct and michaelbrewer reacted with thumbs up emojimichaelbrewer reacted with eyes emoji
@aslilacaslilac requested review froma team andBrunoQuaresma and removed request fora teamMarch 12, 2024 21:19
@aslilacaslilac marked this pull request as ready for reviewMarch 12, 2024 21:19
@BrunoQuaresma
Copy link
Collaborator

I'm missing a test for this use case.

@matifali
Copy link
Member

matifali commentedMar 13, 2024
edited
Loading

Will disabling this point the user to authenticate with the external provider and then auto create the workspace?

@aslilac
Copy link
MemberAuthor

Will disabling this point the user to authenticate with the external provider and then auto create the workspace?

it'll just show them the normal form, and they'll have to click "create" when they've connected.

matifali reacted with thumbs up emoji

@aslilac
Copy link
MemberAuthor

ok, I've hit a weird block with this.

I can add.skip to the new test, and the entire rest of the test suite will pass. I can add.only to the new test, and it will run by itself and pass. but for some reason, in full runs, it causesother tests to fail.

@BrunoQuaresma any ideas why? I tried with msw instead of mocking as well, but that had a similar problem.

@BrunoQuaresma
Copy link
Collaborator

@aslilac Unfortunately I don't 😢 and this is sort of related to the issue that I'm facing here#12597

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I like the test and the new error helper function 👍

@aslilacaslilac merged commit9028717 intomainMar 19, 2024
@aslilacaslilac deleted the pause-auto-mode branchMarch 19, 2024 22:42
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 19, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Launching a workspace withmode=auto does not check for required external authentication for the template
3 participants
@aslilac@BrunoQuaresma@matifali

[8]ページ先頭

©2009-2025 Movatter.jp