- Notifications
You must be signed in to change notification settings - Fork928
fix: disable auto-create if external auth requirements aren't met#12538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I'm missing a test for this use case. |
matifali commentedMar 13, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Will disabling this point the user to authenticate with the external provider and then auto create the workspace? |
it'll just show them the normal form, and they'll have to click "create" when they've connected. |
ok, I've hit a weird block with this. I can add @BrunoQuaresma any ideas why? I tried with msw instead of mocking as well, but that had a similar problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I like the test and the new error helper function 👍
Uh oh!
There was an error while loading.Please reload this page.
Closes#12491
Basically,
mode=auto
should be ignored if a required auth provider is missing