Mar 13, 2024 · Mar 7, 2024 · Mar 8, 2024 · Mar 8, 2024 · Mar 8, 2024 · Mar 8, 2024
diff --git a/coderd/prometheusmetrics/prometheusmetrics_test.go b/coderd/prometheusmetrics/prometheusmetrics_test.go
 "database/sql"
 "encoding/json"
 "fmt"
 "github.com/coder/coder/v2/coderd/agentmetrics"
 "os"
 "reflect"
 "sync/atomic"
 "testing"
 "time"

 "github.com/coder/coder/v2/coderd/agentmetrics"

 "github.com/coder/coder/v2/coderd/batchstats"
 "github.com/coder/coder/v2/coderd/database/dbtestutil"
 "github.com/coder/coder/v2/coderd/database/dbtime"
Original file line number	Diff line number	Diff line change
Expand Up		@@ -5,13 +5,14 @@ import (
		"database/sql"
		"encoding/json"
		"fmt"
		"github.com/coder/coder/v2/coderd/agentmetrics"
		"os"
		"reflect"
		"sync/atomic"
		"testing"
		"time"

		"github.com/coder/coder/v2/coderd/agentmetrics"

		"github.com/coder/coder/v2/coderd/batchstats"
		"github.com/coder/coder/v2/coderd/database/dbtestutil"
		"github.com/coder/coder/v2/coderd/database/dbtime"
Copy link Member mtojekMar 12, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. nit: sorting? Copy link ContributorAuthor dannykoppingMar 12, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Hhmm, I ran`make fmt` and it didn't correct it so I think we have some things to fix in our CI. Will manually sort though 👍 Copy link Member johnstcnMar 12, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. `goimports` only ensures that imports are grouped, but doesn't handle merging multiple import groups from the same source. I recall thathttps://github.com/indeedeng/go-groups was built in anger to address this, but it has not been updated in a while. Copy link ContributorAuthor dannykoppingMar 12, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Oh nice. I just ran it and it... changesa lot. I'll raise a separate PR. Copy link Member johnstcnMar 12, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. It isextremely opinionated
Expand Down