Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: revert "feat: make agent stats' cardinality configurable (#12468)"#12533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 1 commit intomainfromcj/revert-12468
Mar 11, 2024

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedMar 11, 2024
edited
Loading

This reverts commit21d1873.

panic: inconsistent label cardinality: expected 4 label values but got 3 in []string{"dev", "ammar", "c0"}                                                                                                                                ││                                                                                                                                                                                                                                           ││ goroutine 161 [running]:                                                                                                                                                                                                                  ││ github.com/prometheus/client_golang/prometheus.(*GaugeVec).WithLabelValues(...)                                                                                                                                                           ││     /home/runner/go/pkg/mod/github.com/prometheus/client_golang@v1.18.0/prometheus/gauge.go:238                                                                                                                                           ││ github.com/coder/coder/v2/coderd/prometheusmetrics.(*CachedGaugeVec).Commit(0xc00150ee10)                                                                                                                                                 ││     /home/runner/actions-runner/_work/coder/coder/coderd/prometheusmetrics/collector.go:84 +0x191                                                                                                                                         ││ github.com/coder/coder/v2/coderd/prometheusmetrics.AgentStats.func1()                                                                                                                                                                     ││     /home/runner/actions-runner/_work/coder/coder/coderd/prometheusmetrics/prometheusmetrics.go:492 +0x885                                                                                                                                ││ created by github.com/coder/coder/v2/coderd/prometheusmetrics.AgentStats in goroutine 1                                                                                                                                                   ││     /home/runner/actions-runner/_work/coder/coder/coderd/prometheusmetrics/prometheusmetrics.go:448 +0x1445

@johnstcnjohnstcn changed the titleRevert "feat: make agent stats' cardinality configurable (#12468)"fix: revert "feat: make agent stats' cardinality configurable (#12468)"Mar 11, 2024
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Reverting due to apanic: inconsistent label cardinality observed in pre-prod

@johnstcnjohnstcnenabled auto-merge (squash)March 11, 2024 14:30
@johnstcnjohnstcn merged commit8f40ee3 intomainMar 11, 2024
@johnstcnjohnstcn deleted the cj/revert-12468 branchMarch 11, 2024 14:33
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 11, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@dannykoppingdannykoppingdannykopping approved these changes

@mtojekmtojekAwaiting requested review from mtojek

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@johnstcn@mafredri@dannykopping

[8]ページ先頭

©2009-2025 Movatter.jp