NotificationsYou must be signed in to change notification settings
Fork927
Star10.1k

test(coderd): skip flaky dau test#12517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mafredri merged 2 commits intomainfrommafredri/test-skip-flaky-test

Mar 11, 2024

Merged

test(coderd): skip flaky dau test#12517

mafredri merged 2 commits intomainfrommafredri/test-skip-flaky-test

Mar 11, 2024

Conversation

Copy link

Member

mafredri commentedMar 11, 2024•
edited
Loading

This will be fixed by#12122 when the existing DAU queries are replaced by insights queries, disabling for now.

Closes#12509

test(coderd): skip flaky dau test

35086f5

mafredri self-assigned this

Mar 11, 2024

mafredri requested review fromdannykopping andmtojek

March 11, 2024 11:20

mtojek approved these changes

Mar 11, 2024

View reviewed changes

mafredrienabled auto-merge (squash)

March 11, 2024 11:28

dannykopping reviewed

Mar 11, 2024

View reviewed changes

Copy link

Contributor

dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@johnstcn pointed out this test may be failing due to a timezone issue following a recent DST change; I'm happy to try fix it in the interim if needed

Copy link

MemberAuthor

mafredri commentedMar 11, 2024

@johnstcn pointed out this test may be failing due to a timezone issue following a recent DST change; I'm happy to try fix it in the interim if needed

I figured that might be the case, but the DAU count is already inaccurate, so I don't think it's worth spending time on. I won't object if you want to fix it though. 😄