Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(coderd): improve tests for tar<->zip conversion#12477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 5 commits intomainfromcj/fileszip-tests
Mar 11, 2024

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedMar 8, 2024•
edited
Loading

STACK:
#12477 <-- you are here
#12476
#12475
#12479

  • Adds some artisanally handcrafted zip and tar archives undercoderd/testdata
  • Adds test helpers to assert content of above archives
  • Updates existing tests to reference above archives

NOTE: these tests will fail until#12476 is merged in

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just minor nits, nice thorough tests!

func TestCreateTarFromZip(t *testing.T) {
t.Parallel()
if runtime.GOOS != "linux" {
t.Skip("skipping this test on non-Linux platform")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Windows is no bueno?

Copy link
MemberAuthor

@johnstcnjohnstcnMar 8, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Generally yes, but I'm not going to assume the presence oftar andunzip on Windows for this test :-)

@johnstcnjohnstcn merged commitb1ecc53 intomainMar 11, 2024
@johnstcnjohnstcn deleted the cj/fileszip-tests branchMarch 11, 2024 13:29
mtojek pushed a commit that referenced this pull requestMar 11, 2024
* improve tests for tar<->zip conversion* set mode and modtime correctly when converting from zip to tar (#12476)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mafredrimafredrimafredri approved these changes

@mtojekmtojekAwaiting requested review from mtojek

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@johnstcn@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp