- Notifications
You must be signed in to change notification settings - Fork928
fix(coderd): set mode and modtime correctly when converting from zip to tar#12476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
| Mode: 0o644, | ||
| Name: file.Name, | ||
| Size: file.FileInfo().Size(), | ||
| Mode: int64(file.Mode()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
sadly the conversion is required here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
no tests needed?
See#12477 -- this fixes the tests. I suppose these should probably have been the one PR. |
Uh oh!
There was an error while loading.Please reload this page.
STACK:
#12477
#12476 <-- you are here
#12475
#12479
This became apparent when adding tests in#12477