Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(site): add CreateTokenPage story#12472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 1 commit intomainfrombq/add-stories-create-token-page
Mar 11, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

FYI: Tried to run a few scenarios but it was failing for me when trying to spy on the API methods. Opened a bug on Storybook repo:storybookjs/storybook#26386

Related to#12263

@BrunoQuaresmaBrunoQuaresma self-assigned thisMar 8, 2024
@aslilac
Copy link
Member

Could you just specifyparameters.queries on the individual stories instead of spying/mocking?

@@ -21,6 +22,8 @@ import {
customLifetimeDay,
} from "./utils";

dayjs.extend(utc);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've seen Storybook catch so many of these "depending on a dayjs plugin that we don't actually install locally" bugs. 🐛

BrunoQuaresma reacted with thumbs up emoji
@BrunoQuaresmaGraphite App
Copy link
CollaboratorAuthor

Could you just specifyparameters.queries on the individual stories instead of spying/mocking?

They don't work for mutations 😥

Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ah, right. fair enough!

@BrunoQuaresmaBrunoQuaresma merged commit83af867 intomainMar 11, 2024
@BrunoQuaresmaBrunoQuaresma deleted the bq/add-stories-create-token-page branchMarch 11, 2024 17:10
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 11, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@BrunoQuaresma@aslilac

[8]ページ先頭

©2009-2025 Movatter.jp