Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(cli): make url optional for login command (#10925)#12466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 4 commits intocoder:mainfromelasticspoon:cli-use-config-url
Mar 11, 2024

Conversation

elasticspoon
Copy link
Contributor

@elasticspoonelasticspoon commentedMar 8, 2024•
edited by mafredri
Loading

Allowcoder login to log into existing deployment if available and indicate URL used.

$> go run ./cmd/coder/main.go loginAttempting to authenticate with saved URL: http://localhost:8080Your browser has been opened to visit:        http://localhost:8080/cli-auth> Paste your token here: KtJjNBnP6D-EiYB7ADdUfOBBn66lVLXTy> Welcome to Coder, admin! You're authenticated.

This PR also updates related error and help messages to indicatecoder login is available as a command.

Fixes#10925
Fixes#9551

@cdr-botcdr-botbot added the communityPull Requests and issues created by the community. labelMar 8, 2024
@github-actionsGitHub Actions
Copy link

github-actionsbot commentedMar 8, 2024•
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@elasticspoon
Copy link
ContributorAuthor

I have read the CLA Document and I hereby sign the CLA

cdrcommunity added a commit to coder/cla that referenced this pull requestMar 8, 2024
@elasticspoonelasticspoon marked this pull request as ready for reviewMarch 8, 2024 01:29
Allow `coder login` to log into existing deployment if available.Output to indicate saved URL was used.Update help and error messages to indicate that `coder login` isavailable as a command.
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for this PR! I have a couple of improvement suggestions but otherwise this looks really good.

It doesn't make sense to output Authing with ...then fail. This moves the output later in the loginprocess to prevent that.
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This turned out great, thanks for your contribution!

@mafredrimafredri merged commit773862a intocoder:mainMar 11, 2024
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 11, 2024
@elasticspoonelasticspoon deleted the cli-use-config-url branchMarch 11, 2024 14:29
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@elasticspoonelasticspoon

Labels
communityPull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve coder cli re-login experience when api token is expired UX: coder cli should read login URL from file if not given
2 participants
@elasticspoon@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp