- Notifications
You must be signed in to change notification settings - Fork928
chore: add stories forMoreMenu
#12464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good! Have one other question with the story output itself, but if you don't think it'll be a problem for now, I can approve
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Parkreiner commentedMar 8, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There's something a little weird happening with the list items, where the indicator for the last-selected item with the arrow keys is visually conflicting with whichever list item is being hovered Screen.Recording.2024-03-08.at.9.42.18.AM.movI don't know what the plan is for the story rollout, so if this isn't a concern for now, I can approve this regardless My main concern is using Stories to cement functionality we know for a fact is wonky. Though if the Storybook actions are powerful enough, maybe we could include checks for things like this (if not now, then down the line) |
aslilac commentedMar 8, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I've opened an issue (#12482) to track the weird selection state so that we can take care of it later, but for now, since it's already in the app and no one has complained yet, I don't want to block adding the story on fixing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@aslilac Okay, cool. Approving
Part of#11420
Part of#12261