Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add stories forMoreMenu#12464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 4 commits intomainfrommore-menu-stories
Mar 8, 2024
Merged

chore: add stories forMoreMenu#12464

aslilac merged 4 commits intomainfrommore-menu-stories
Mar 8, 2024

Conversation

aslilac
Copy link
Member

Part of#11420
Part of#12261

@aslilacaslilac requested review froma team andParkreiner and removed request fora teamMarch 7, 2024 23:24
Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good! Have one other question with the story output itself, but if you don't think it'll be a problem for now, I can approve

@Parkreiner
Copy link
Member

Parkreiner commentedMar 8, 2024
edited
Loading

There's something a little weird happening with the list items, where the indicator for the last-selected item with the arrow keys is visually conflicting with whichever list item is being hovered

Screen.Recording.2024-03-08.at.9.42.18.AM.mov

I don't know what the plan is for the story rollout, so if this isn't a concern for now, I can approve this regardless

My main concern is using Stories to cement functionality we know for a fact is wonky. Though if the Storybook actions are powerful enough, maybe we could include checks for things like this (if not now, then down the line)

@aslilac
Copy link
MemberAuthor

aslilac commentedMar 8, 2024
edited
Loading

I've opened an issue (#12482) to track the weird selection state so that we can take care of it later, but for now, since it's already in the app and no one has complained yet, I don't want to block adding the story on fixing it.

@aslilacaslilac requested a review fromParkreinerMarch 8, 2024 18:45
Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@aslilac Okay, cool. Approving

aslilac reacted with heart emoji
@aslilacaslilac merged commitcf4f56d intomainMar 8, 2024
@aslilacaslilac deleted the more-menu-stories branchMarch 8, 2024 19:01
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 8, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ParkreinerParkreinerParkreiner approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslilac@Parkreiner

[8]ページ先頭

©2009-2025 Movatter.jp