Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add stories forLoader#12445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 3 commits intomainfromadd-loader-stories
Mar 8, 2024
Merged

chore: add stories forLoader#12445

aslilac merged 3 commits intomainfromadd-loader-stories
Mar 8, 2024

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedMar 6, 2024
edited
Loading

Part of#11420
Part of#12261

Snuck in a minor refactor to get rid of theFullScreenLoader component

@aslilacaslilac requested review froma team andKira-Pilot and removed request fora teamMarch 6, 2024 18:56
@aslilacaslilac requested a review fromKira-PilotMarch 7, 2024 22:27
@aslilac
Copy link
MemberAuthor

I just removeddata-chromatic="ignore" and it didn't show a diff in Chromatic at all, so...I guess it's fine? I think it might just be black because the first/last frame is "empty" (since the spinner shrinks and grows).

Kira-Pilot reacted with thumbs up emoji

@aslilacaslilac merged commit8d8220b intomainMar 8, 2024
@aslilacaslilac deleted the add-loader-stories branchMarch 8, 2024 18:35
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 8, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslilac@Kira-Pilot

[8]ページ先頭

©2009-2025 Movatter.jp