Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: ensure agent token is from latest build in middleware#12443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
f0ssel merged 21 commits intomainfromf0ssel/ensure-latest-mw
Mar 14, 2024
Merged
Changes from1 commit
Commits
Show all changes
21 commits
Select commitHold shift + click to select a range
8a9cde8
fix: ensure agent token is from latest build in middleware
f0sselMar 6, 2024
d294d44
fix typo
f0sselMar 6, 2024
9fbedb3
fix context
f0sselMar 8, 2024
e24809b
fix test
f0sselMar 8, 2024
e239ac5
revert test change
f0sselMar 8, 2024
f06823f
use httmw latest build
f0sselMar 8, 2024
69c8abf
change extraction name
f0sselMar 8, 2024
1676041
change config name
f0sselMar 8, 2024
e676e77
add test
f0sselMar 11, 2024
8417ea9
cleanup test code
f0sselMar 11, 2024
67bad86
increment build number
f0sselMar 11, 2024
648aa29
remove agent
f0sselMar 11, 2024
a2bccaa
update comment
f0sselMar 11, 2024
8dc5e0b
cleanup names
f0sselMar 11, 2024
e72f385
simplify query
f0sselMar 13, 2024
7f41a85
fix tests
f0sselMar 13, 2024
7c0af4f
lint
f0sselMar 13, 2024
267af76
fix type generation for build
f0sselMar 13, 2024
7e06fdd
fix status code
f0sselMar 13, 2024
0915a97
add deleted clause
f0sselMar 13, 2024
ca39368
fix gentest
f0sselMar 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
fix test
  • Loading branch information
@f0ssel
f0ssel committedMar 8, 2024
commite24809bfd7d3cca0641494a9429d831ff23f3f9e
84 changes: 45 additions & 39 deletionscli/vscodessh_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,19 @@
package cli_test

import (
"context"
"fmt"
"testing"

"github.com/spf13/afero"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"github.com/coder/coder/v2/agent/agenttest"
"github.com/coder/coder/v2/cli/clitest"
"github.com/coder/coder/v2/coderd/coderdtest"
"github.com/coder/coder/v2/codersdk"
"github.com/coder/coder/v2/pty/ptytest"
"github.com/coder/coder/v2/testutil"
)

Expand All@@ -17,46 +23,46 @@ func TestVSCodeSSH(t *testing.T) {
t.Parallel()
ctx := testutil.Context(t, testutil.WaitLong)
client, workspace, agentToken := setupWorkspaceForAgent(t)
_, err := client.User(ctx, codersdk.Me)
user, err := client.User(ctx, codersdk.Me)
require.NoError(t, err)

_ = agenttest.New(t, client.URL, agentToken)
_ = coderdtest.NewWorkspaceAgentWaiter(t, client, workspace.ID).Wait()

//fs := afero.NewMemMapFs()
//err = afero.WriteFile(fs, "/url", []byte(client.URL.String()), 0o600)
//require.NoError(t, err)
//err = afero.WriteFile(fs, "/token", []byte(client.SessionToken()), 0o600)
//require.NoError(t, err)

// //nolint:revive,staticcheck
//ctx = context.WithValue(ctx, "fs", fs)

//inv, _ := clitest.New(t,
//"vscodessh",
//"--url-file", "/url",
//"--session-token-file", "/token",
//"--network-info-dir", "/net",
//"--log-dir", "/log",
//"--network-info-interval", "25ms",
//fmt.Sprintf("coder-vscode--%s--%s", user.Username, workspace.Name),
//)
//ptytest.New(t).Attach(inv)

//waiter := clitest.StartWithWaiter(t, inv.WithContext(ctx))

//for _, dir := range []string{"/net", "/log"} {
//assert.Eventually(t, func() bool {
//entries, err := afero.ReadDir(fs, dir)
//if err != nil {
//return false
//}
//return len(entries) > 0
//}, testutil.WaitLong, testutil.IntervalFast)
//}
//waiter.Cancel()

//if err := waiter.Wait(); err != nil {
//waiter.RequireIs(context.Canceled)
//}
_ = coderdtest.AwaitWorkspaceAgents(t, client, workspace.ID)

fs := afero.NewMemMapFs()
err = afero.WriteFile(fs, "/url", []byte(client.URL.String()), 0o600)
require.NoError(t, err)
err = afero.WriteFile(fs, "/token", []byte(client.SessionToken()), 0o600)
require.NoError(t, err)

//nolint:revive,staticcheck
ctx = context.WithValue(ctx, "fs", fs)

inv, _ := clitest.New(t,
"vscodessh",
"--url-file", "/url",
"--session-token-file", "/token",
"--network-info-dir", "/net",
"--log-dir", "/log",
"--network-info-interval", "25ms",
fmt.Sprintf("coder-vscode--%s--%s", user.Username, workspace.Name),
)
ptytest.New(t).Attach(inv)

waiter := clitest.StartWithWaiter(t, inv.WithContext(ctx))

for _, dir := range []string{"/net", "/log"} {
assert.Eventually(t, func() bool {
entries, err := afero.ReadDir(fs, dir)
if err != nil {
return false
}
return len(entries) > 0
}, testutil.WaitLong, testutil.IntervalFast)
}
waiter.Cancel()

if err := waiter.Wait(); err != nil {
waiter.RequireIs(context.Canceled)
}
}

[8]ページ先頭

©2009-2025 Movatter.jp