- Notifications
You must be signed in to change notification settings - Fork928
fix: display tooltip when selection is disabled#12439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I don't know if a tooltip is a good option here since it is a popover on top of the other 2 popovers. Ports popover -> Sharing level menu -> Toopltip. The menu items can accept any React elements so I think the content in the tooltip could be an item description like the email in the image below:  Wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I will leave it to you to decide if a tooltip would be better than what I suggested in the previous comment.
I do like your suggestion, but I think we can leave it for when we take another look at this design, and we can live with the tooltip for now. Thanks for the review. |
Uh oh!
There was an error while loading.Please reload this page.
Screenshot is missing mouse but this is on hover.