Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: allow proxy version mismatch (with warning)#12433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deansheather merged 4 commits intomainfromdean/allow-mismatched-proxy-versions
Mar 20, 2024

Conversation

deansheather
Copy link
Member

@deansheatherdeansheather commentedMar 5, 2024•
edited
Loading

  • Removes version check from register endpoint which causes proxies to enter crash loop backoff
  • ProxyHealth already checks versions and reports them as warnings
  • The proxy now prints a warning on startup if the version doesn't match

TODO:

  • Manually test

Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fair. The strict version checking was overkill.

matifali reacted with thumbs up emoji
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelMar 13, 2024
@deansheatherdeansheather removed the staleThis issue is like stale bread. labelMar 18, 2024
@deansheather
Copy link
MemberAuthor

Version mismatch:
image

2024-03-18 13:33:49.669 [warn]  workspace proxy version doesn't match Minor.Major version of the primary, please keep them in sync  primary_version=v2.8.0-devel+5e01b030a  proxy_version=v1.10.0

Version match:
image

In both cases still selectable from the UI.

@deansheatherdeansheatherenabled auto-merge (squash)March 20, 2024 07:41
@deansheatherdeansheather merged commit2b773f9 intomainMar 20, 2024
@deansheatherdeansheather deleted the dean/allow-mismatched-proxy-versions branchMarch 20, 2024 18:24
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 20, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

Assignees

@deansheatherdeansheather

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@deansheather@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp