Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add stories forPopover#12387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 1 commit intomainfrompopover-stories
Mar 1, 2024
Merged

chore: add stories forPopover#12387

aslilac merged 1 commit intomainfrompopover-stories
Mar 1, 2024

Conversation

aslilac
Copy link
Member

Part of#11420
Part of#12261

Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!
Had to read up on what theplay methods do, and they seem straightforward. Just making sure, though: if aplay action fails, that makes the story fail in Chromatic, right?

@aslilac
Copy link
MemberAuthor

Just making sure, though: if a play action fails, that makes the story fail in Chromatic, right?

Correct.play is the interface for the @storybook/actions testing that I've been so pomp about lately, and Chromatic integrates with it very nicely.

@aslilacaslilac merged commitaf4d0b1 intomainMar 1, 2024
@aslilacaslilac deleted the popover-stories branchMarch 1, 2024 22:43
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 1, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ParkreinerParkreinerParkreiner approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslilac@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp