- Notifications
You must be signed in to change notification settings - Fork926
fix(site): retry and debug passing build parameters options#12384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| rest.get("/api/v2/integrations/jfrog/xray-scan", (_, res, ctx) => { | ||
| return res(ctx.status(404)); | ||
| }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why did we add these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
To avoid getting unhandled request warnings during tests. The warning was introduced many PRs ago but I only noticed it now since it was messing with the output for my tests so I just fixed it.
| @@ -438,4 +438,102 @@ describe("WorkspacePage", () => { | |||
| }); | |||
| }); | |||
| }); | |||
| it("retry with build parameters", async () => { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nice!
| ...MockTemplateVersionParameter1, | ||
| display_name: "Parameter 1", | ||
| ephemeral: true, | ||
| } satisfies TemplateVersionParameter; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why do we have to usesatisifes here and above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
When typing the variable directly it was missing a few attribute types after destructuring so usingsatisfies fixed that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
When Storybook is happy I'm happy!
Close#11748