Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Use environment variables for agent authentication#1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 3 commits intomainfromfixgit
Apr 30, 2022
Merged

Conversation

kylecarbs
Copy link
Member

Using files led to situations where running "coder server --dev" would
breakgitssh. This is applicable in a production environment too. Users
should be able to log into another Coder deployment from their workspace.

Users can still set "CODER_URL" if they'd like with agent env vars!

This was a mistake when adding the committer fields 🤦.
@kylecarbskylecarbs self-assigned thisApr 30, 2022
Using files led to situations where running "coder server --dev" wouldbreak `gitssh`. This is applicable in a production environment too. Usersshould be able to log into another Coder deployment from their workspace.Users can still set "CODER_URL" if they'd like with agent env vars!
@codecov
Copy link

codecovbot commentedApr 30, 2022•
edited
Loading

Codecov Report

Merging#1238 (b52d56a) intomain (eb60692) willdecrease coverage by0.10%.
The diff coverage is70.66%.

@@            Coverage Diff             @@##             main    #1238      +/-   ##==========================================- Coverage   65.84%   65.73%   -0.11%==========================================  Files         272      270       -2       Lines       17875    17865      -10       Branches      192      192              ==========================================- Hits        11770    11744      -26- Misses       4878     4885       +7- Partials     1227     1236       +9
FlagCoverage Δ
unittest-go-macos-latest?
unittest-go-postgres-64.77% <69.33%> (+0.06%)⬆️
unittest-go-ubuntu-latest55.54% <69.33%> (-0.14%)⬇️
unittest-go-windows-202252.84% <69.33%> (-0.02%)⬇️
unittest-js69.96% <ø> (ø)
Impacted FilesCoverage Δ
cli/config/file.go76.47% <ø> (-1.31%)⬇️
provisionersdk/agent.go100.00% <ø> (ø)
cli/gitssh.go43.13% <50.00%> (-1.31%)⬇️
agent/agent.go65.62% <65.21%> (-1.47%)⬇️
cli/agent.go85.00% <69.23%> (+4.62%)⬆️
cli/root.go77.69% <70.00%> (+0.41%)⬆️
cli/cliflag/cliflag.go100.00% <100.00%> (ø)
provisioner/terraform/provision.go70.96% <100.00%> (ø)
cli/cliui/agent.go77.19% <0.00%> (-5.27%)⬇️
peer/conn.go74.68% <0.00%> (-4.97%)⬇️
... and11 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateeb60692...b52d56a. Read thecomment docs.

Copy link
Member

@code-ashercode-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have not had a chance to test yet but the code looks great to me

@code-asher
Copy link
Member

code-asher commentedApr 30, 2022•
edited
Loading

My workspaces are not starting for some reason so I was not able to fully test but I was able to at least confirm that settingCODER_AGENT_URL andCODER_AGENT_TOKEN made thegitssh command work again.

One unexpected struggle I had was that I was running from a v1 workspace whereCODER_URL is set making all my commands start failing so something to look out for if anyone is still developing v2 in v1. Sounds to me like that means it is time to migrate to v2 though!

kylecarbs reacted with thumbs up emoji

@kylecarbskylecarbsenabled auto-merge (squash)April 30, 2022 16:35
@kylecarbskylecarbs merged commitb948f2d intomainApr 30, 2022
@kylecarbskylecarbs deleted the fixgit branchApril 30, 2022 16:40
kylecarbs added a commit that referenced this pull requestJun 10, 2022
* fix: Update GIT_COMMITTER_NAME to use usernameThis was a mistake when adding the committer fields 🤦.* fix: Use environment variables for agent authenticationUsing files led to situations where running "coder server --dev" wouldbreak `gitssh`. This is applicable in a production environment too. Usersshould be able to log into another Coder deployment from their workspace.Users can still set "CODER_URL" if they'd like with agent env vars!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@code-ashercode-ashercode-asher approved these changes

@coadlercoadlerAwaiting requested review from coadler

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@kylecarbs@code-asher
[8]ページ先頭
©2009-2025 Movatter.jp