NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

fix: Add "GIT_COMMITTER_*" to remove Git prompt#1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

coadler merged 1 commit intomainfromgitflags

Apr 30, 2022

Merged

fix: Add "GIT_COMMITTER_*" to remove Git prompt#1236

coadler merged 1 commit intomainfromgitflags

Apr 30, 2022

Conversation

Copy link

Member

kylecarbs commentedApr 29, 2022

A prompt would appear to globally configure the email or name
before. We already have this information, so we can set the
environment variables!

fix: Add "GIT_COMMITTER_*" to remove Git prompt

902aaca

A prompt would appear to globally configure the email or namebefore. We already have this information, so we can set theenvironment variables!

kylecarbs requested review fromEmyrk andcoadler

April 29, 2022 23:11

kylecarbs self-assigned this

Apr 29, 2022

Copy link

codecovbot commentedApr 29, 2022•
edited
Loading

Codecov Report

Merging#1236 (902aaca) intomain (81577f1) willincrease coverage by0.50%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #1236      +/-   ##==========================================+ Coverage   65.33%   65.83%   +0.50%==========================================  Files         266      272       +6       Lines       17651    17875     +224       Branches      192      192              ==========================================+ Hits        11532    11768     +236+ Misses       4880     4879       -1+ Partials     1239     1228      -11

Flag	Coverage Δ
unittest-go-macos-latest	`53.23% <100.00%> (?)`
unittest-go-postgres-	`64.84% <100.00%> (-0.02%)`	⬇️
unittest-go-ubuntu-latest	`55.58% <100.00%> (?)`
unittest-go-windows-2022	`52.77% <100.00%> (?)`
unittest-js	`69.96% <ø> (ø)`

Impacted Files	Coverage Δ
agent/agent.go	`67.08% <100.00%> (+2.12%)`	⬆️
peerbroker/dial.go	`77.04% <0.00%> (-6.56%)`	⬇️
peerbroker/listen.go	`82.35% <0.00%> (-3.37%)`	⬇️
cli/cliui/provisionerjob.go	`76.42% <0.00%> (-2.15%)`	⬇️
pty/start_windows.go	`66.95% <0.00%> (ø)`
cli/cliui/cliui_darwin.go	`0.00% <0.00%> (ø)`
agent/usershell/usershell_darwin.go	`100.00% <0.00%> (ø)`
agent/usershell/usershell_windows.go	`83.33% <0.00%> (ø)`
pty/pty_windows.go	`74.62% <0.00%> (ø)`
cli/ssh_windows.go	`0.00% <0.00%> (ø)`
... and16 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update81577f1...902aaca. Read thecomment docs.