- Notifications
You must be signed in to change notification settings - Fork928
fix: separate signals for passive, active, and forced shutdown#12358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
8d160ae
210a143
4c6a1d2
afc2dc0
3c9254a
67db53c
bf60566
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -7,8 +7,23 @@ import ( | ||
"syscall" | ||
) | ||
// StopSignals is the list of signals that are used for handling | ||
// shutdown behavior. | ||
var StopSignals = []os.Signal{ | ||
os.Interrupt, | ||
syscall.SIGTERM, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. This is a breaking change in all CLI commands that handle signals. They used to handle | ||
syscall.SIGHUP, | ||
} | ||
// StopSignals is the list of signals that are used for handling | ||
// graceful shutdown behavior. | ||
var StopSignalsNoInterrupt = []os.Signal{ | ||
syscall.SIGTERM, | ||
syscall.SIGHUP, | ||
} | ||
// InterruptSignals is the list of signals that are used for handling | ||
// immediate shutdown behavior. | ||
var InterruptSignals = []os.Signal{ | ||
os.Interrupt, | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -6,4 +6,12 @@ import ( | ||
"os" | ||
) | ||
var StopSignals = []os.Signal{ | ||
os.Interrupt, | ||
} | ||
var StopSignalsNoInterrupt = []os.Signal{} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I love how Windows leaves you SOL. 🥲 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. No doubt! | ||
var InterruptSignals = []os.Signal{ | ||
os.Interrupt, | ||
} |
Uh oh!
There was an error while loading.Please reload this page.