Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test: Regenerate GitSSHKey flake when comparing times#1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromgitkeyflake
Apr 30, 2022

Conversation

kylecarbs
Copy link
Member

This is a crazy one! The in-memory DB is fast, which allows the same
exact timestamp to occur for regenerating the key!

See:https://github.com/coder/coder/runs/6234173911?check_suite_focus=true#step:9:82

bpmct reacted with eyes emoji
This is a crazy one! The in-memory DB is fast, which allows the sameexact timestamp to occur for regenerating the key!See:https://github.com/coder/coder/runs/6234173911?check_suite_focus=true#step:9:82
@kylecarbskylecarbs requested a review fromf0sselApril 29, 2022 22:57
@kylecarbskylecarbs self-assigned thisApr 29, 2022
@kylecarbs
Copy link
MemberAuthor

Happened in#1231

@codecov
Copy link

codecovbot commentedApr 29, 2022•
edited
Loading

Codecov Report

Merging#1235 (7f62505) intomain (81577f1) willincrease coverage by0.43%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #1235      +/-   ##==========================================+ Coverage   65.33%   65.76%   +0.43%==========================================  Files         266      272       +6       Lines       17651    17872     +221       Branches      192      192              ==========================================+ Hits        11532    11754     +222- Misses       4880     4886       +6+ Partials     1239     1232       -7
FlagCoverage Δ
unittest-go-macos-latest53.19% <ø> (?)
unittest-go-postgres-64.83% <ø> (-0.02%)⬇️
unittest-go-ubuntu-latest55.54% <ø> (?)
unittest-go-windows-202252.76% <ø> (?)
unittest-js69.96% <ø> (ø)
Impacted FilesCoverage Δ
peerbroker/dial.go77.04% <0.00%> (-6.56%)⬇️
cli/cliui/provisionerjob.go76.42% <0.00%> (-2.15%)⬇️
coderd/workspaceagents.go56.77% <0.00%> (-0.94%)⬇️
provisionerd/provisionerd.go75.76% <0.00%> (-0.54%)⬇️
coderd/provisionerdaemons.go62.79% <0.00%> (ø)
pty/pty_windows.go74.62% <0.00%> (ø)
cli/ssh_windows.go0.00% <0.00%> (ø)
agent/usershell/usershell_windows.go83.33% <0.00%> (ø)
cli/cliui/cliui_darwin.go0.00% <0.00%> (ø)
pty/start_windows.go66.95% <0.00%> (ø)
... and16 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update81577f1...7f62505. Read thecomment docs.

@kylecarbskylecarbs merged commite15566c intomainApr 30, 2022
@kylecarbskylecarbs deleted the gitkeyflake branchApril 30, 2022 01:19
kylecarbs added a commit that referenced this pull requestJun 10, 2022
This is a crazy one! The in-memory DB is fast, which allows the sameexact timestamp to occur for regenerating the key!See:https://github.com/coder/coder/runs/6234173911?check_suite_focus=true#step:9:82
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@f0sself0sself0ssel approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@kylecarbs@f0ssel
[8]ページ先頭
©2009-2025 Movatter.jp