NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

fix: clarify AWS access key ID vs secret#1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bpmct merged 1 commit intomainfrombpmct/aws-clarify

May 2, 2022

Merged

fix: clarify AWS access key ID vs secret#1231

bpmct merged 1 commit intomainfrombpmct/aws-clarify

May 2, 2022

Conversation

Copy link

Member

bpmct commentedApr 29, 2022

This is how AWS differentiates access key vs secret

fix: clarify AWS access key ID vs secret

2780429

bpmct requested a review frompresleyp

April 29, 2022 19:42

Copy link

codecovbot commentedApr 29, 2022•
edited
Loading

Codecov Report

Merging#1231 (2780429) intomain (021e4cd) willincrease coverage by0.02%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #1231      +/-   ##==========================================+ Coverage   65.65%   65.68%   +0.02%==========================================  Files         269      269                Lines       17366    17366                Branches      164      164              ==========================================+ Hits        11402    11407       +5+ Misses       4772     4770       -2+ Partials     1192     1189       -3

Flag	Coverage Δ
unittest-go-macos-latest	`52.95% <ø> (-0.05%)`	⬇️
unittest-go-postgres-	`64.73% <ø> (-0.06%)`	⬇️
unittest-go-ubuntu-latest	`55.42% <ø> (+0.03%)`	⬆️
unittest-go-windows-2022	`52.60% <ø> (+0.08%)`	⬆️
unittest-js	`68.87% <ø> (ø)`

Impacted Files	Coverage Δ
coderd/workspaceagents.go	`55.59% <0.00%> (-2.56%)`	⬇️
cli/cliui/provisionerjob.go	`76.42% <0.00%> (-2.15%)`	⬇️
peer/channel.go	`83.81% <0.00%> (-1.16%)`	⬇️
peerbroker/proxy.go	`58.13% <0.00%> (-0.59%)`	⬇️
coderd/provisionerdaemons.go	`62.28% <0.00%> (-0.51%)`	⬇️
provisionerd/provisionerd.go	`76.30% <0.00%> (+0.13%)`	⬆️
provisioner/terraform/provision.go	`71.39% <0.00%> (+0.43%)`	⬆️
peer/conn.go	`78.16% <0.00%> (+1.48%)`	⬆️
peerbroker/listen.go	`87.39% <0.00%> (+3.36%)`	⬆️
provisioner/echo/serve.go	`59.20% <0.00%> (+4.80%)`	⬆️
... and1 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update021e4cd...2780429. Read thecomment docs.