Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Use verified and primary email for GitHub signup#1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromghpanic
Apr 29, 2022

Conversation

kylecarbs
Copy link
Member

This was causing a panic due to nil pointer dereference.
It required all users signing up had a public email,
which is an unreasonable requirement!

This was causing a panic due to nil pointer dereference.It required all users signing up had a public email,which is an unreasonable requirement!
@codecov
Copy link

codecovbot commentedApr 29, 2022•
edited
Loading

Codecov Report

Merging#1230 (7bf8a78) intomain (35211e2) willincrease coverage by0.02%.
The diff coverage is42.85%.

@@            Coverage Diff             @@##             main    #1230      +/-   ##==========================================+ Coverage   65.63%   65.66%   +0.02%==========================================  Files         269      269                Lines       17337    17378      +41       Branches      162      164       +2     ==========================================+ Hits        11379    11411      +32- Misses       4768     4776       +8- Partials     1190     1191       +1
FlagCoverage Δ
unittest-go-macos-latest52.97% <42.85%> (+0.04%)⬆️
unittest-go-postgres-64.71% <42.85%> (+<0.01%)⬆️
unittest-go-ubuntu-latest55.43% <42.85%> (+0.08%)⬆️
unittest-go-windows-202252.53% <42.85%> (-0.02%)⬇️
unittest-js68.87% <ø> (+0.02%)⬆️
Impacted FilesCoverage Δ
coderd/userauth.go54.16% <42.85%> (-4.17%)⬇️
site/src/pages/UsersPage/UsersPage.tsx75.00% <0.00%> (-7.36%)⬇️
peerbroker/dial.go77.04% <0.00%> (-6.56%)⬇️
coderd/workspaceagents.go55.59% <0.00%> (-2.56%)⬇️
site/src/xServices/users/usersXService.ts80.00% <0.00%> (-1.25%)⬇️
site/src/api/index.ts65.30% <0.00%> (ø)
provisioner/echo/serve.go56.80% <0.00%> (ø)
site/src/testHelpers/entities.ts100.00% <0.00%> (ø)
site/src/pages/UsersPage/UsersPageView.tsx100.00% <0.00%> (ø)
... and7 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update35211e2...7bf8a78. Read thecomment docs.

Copy link
Contributor

@f0sself0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should document this somewhere, I feel like people will 100% run into this and the answer will be "make sure the email you are expecting is the primary". Not sure the best place to put that today.

@kylecarbskylecarbs self-assigned thisApr 29, 2022
@kylecarbs
Copy link
MemberAuthor

I think we'll need a better answer to how we do the email verification in general before launch, so we'll grab some customer feedback.

@kylecarbskylecarbs merged commit23e5636 intomainApr 29, 2022
@kylecarbskylecarbs deleted the ghpanic branchApril 29, 2022 20:13
kylecarbs added a commit that referenced this pull requestJun 10, 2022
This was causing a panic due to nil pointer dereference.It required all users signing up had a public email,which is an unreasonable requirement!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@coadlercoadlercoadler approved these changes

@f0sself0sself0ssel approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@kylecarbs@coadler@f0ssel
[8]ページ先頭
©2009-2025 Movatter.jp