- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: use v2 API for agent metadata updates#12281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
spikecurtis commentedFeb 23, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@spikecurtis and the rest of your teammates on |
| // we're only interested about up-to-date values. | ||
| updatedMetadata[mr.key]=mr.result | ||
| continue | ||
| caseerr:=<-reportError: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FYI: I moved this up to the main select so that if there is an error, we won't wait around until the next tick to exit.
359baae toce4323cComparece4323c toab6a2a5Compare
mafredri left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Minor nits but otherwise LGTM!
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
ab6a2a5 toe06b9b7Comparespikecurtis commentedFeb 26, 2024
Merge activity
|
Uh oh!
There was an error while loading.Please reload this page.
Switches the agent to report metadata over the v2 API.
Fixes#10534