Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: use v2 API for agent lifecycle updates#12278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/10534-lifecycle-update
Feb 23, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedFeb 23, 2024•
edited
Loading

Agent uses the v2 API to post lifecycle updates.

Part of#10534

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedFeb 23, 2024•
edited
Loading

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@spikecurtis and the rest of your teammates onGraphiteGraphite

@spikecurtisspikecurtis marked this pull request as ready for reviewFebruary 23, 2024 09:50
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some tests need updating (relying on removedagentClient.PostLifecycle), but otherwise LGTM!

lastReportedIndex++
continue
}
logger := a.logger.With(slog.F("payload", l))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nit: Thepayload should bepayload := &proto.UpdateLifecycleRequest{Lifecycle: l}, as that's what's being sent.

@spikecurtisspikecurtisforce-pushed thespike/10534-lifecycle-update branch from0e7b180 to5586ecfCompareFebruary 23, 2024 10:50
@spikecurtisGraphite App
Copy link
ContributorAuthor

Thanks! Going to keep the PostLifecycle around, but deprecated so that we have tests against the v1 API.

We can retire it all when we drop v1 support.

@spikecurtisspikecurtisforce-pushed thespike/10534-lifecycle-update branch from5586ecf toc17735dCompareFebruary 23, 2024 11:13
@spikecurtisspikecurtis merged commitaa7a9f5 intomainFeb 23, 2024
@spikecurtisspikecurtis deleted the spike/10534-lifecycle-update branchFebruary 23, 2024 11:24
@spikecurtisGraphite App
Copy link
ContributorAuthor

Merge activity

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 23, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp