- Notifications
You must be signed in to change notification settings - Fork928
feat: implement global flag for org selection#12276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
b1151b0 toa69748cCompare Closed
mafredri approved these changesFeb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry for the delayed review, missed this PR last week.
cli/root.go Outdated
| Flag: varOrganizationSelect, | ||
| FlagShorthand: "z", | ||
| Env: "CODER_ORGANIZATION", | ||
| Description: "Select which organization (uuid or name) to use as default. This overrides what is present in the config file.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
| Description:"Select which organization (uuid or name) to use as default. This overrides what is present in the config file.", | |
| Description:"Select which organization (uuid or name) to use. This overrides what is present in the config file.", |
I think the default terminology here could be confusing.
fd99c71 to3eff62aCompareAny command can use '-z' to override org context
3eff62a tof1fcf31CompareSign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
What this does
Adds a flag
-z <org_name | org_id>that selects a given org. Works on all commands. This allows overriding whatever is in the config setting.I used
-zrather than-obecause-ois used for--output.