- Notifications
You must be signed in to change notification settings - Fork928
fix(coderd): only allow untagged provisioners to pick up untagged jobs#12269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| { | ||
| name: "tagged provisioner and untagged job", | ||
| provisionerJobTags: map[string]string{"scope": "organization", "owner": ""}, | ||
| acquireJobTags: map[string]string{"scope": "organization", "owner": "", "foo": "bar"}, | ||
| expectAcquire: false, | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
review: this is the behaviour that changes
| AND nested.tags <@ @tags :: jsonb | ||
| AND CASE | ||
| -- Special case for untagged provisioners: only match untagged jobs. | ||
| WHEN nested.tags :: jsonb = '{"scope": "organization", "owner": ""}' :: jsonb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
When we assign @ tags, will it always containscope = organization when untagged and used live?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We make sure to callprovisionersdk.MutateTags before serializing tags, so it will always containscope andowner keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
Uh oh!
There was an error while loading.Please reload this page.
Alternative solution to#6442
Modifies the behaviour of
AcquireProvisionerJoband adds a special case for 'un-tagged' jobs such that they can only be picked up by 'un-tagged' provisioners.Also adds comprehensive test coverage for
AcquireJobgiven various combinations of tags.This solves the issue described in#6442 without the need for another configuration knob.
The approach in#12244 needs some additional supporting work and potentially some input from customers before we go ahead and build it properly.
This is a behavioural change for sure, but there doesn't seem to be any scenario in which the previous behaviour would be warranted.