Feb 22, 2024 · Feb 22, 2024 · Feb 22, 2024 · Feb 22, 2024
diff --git a/cli/ssh_test.go b/cli/ssh_test.go
 assert.NoError(t, err)
 })

 tGo(t, func() {
 // When the agent connects, the workspace was started, and we should
 // have access to the shell.
 _ = agenttest.New(t, client.URL, authToken)
 coderdtest.NewWorkspaceAgentWaiter(t, client, workspace.ID).Wait()
 })
 // When the agent connects, the workspace was started, and we should
 // have access to the shell.
 _ = agenttest.New(t, client.URL, authToken)

 conn, channels, requests, err := ssh.NewClientConn(&stdioConn{
 Reader: proxyCommandStdoutR,
Original file line number	Diff line number	Diff line change
Expand Up		@@ -455,12 +455,9 @@ func TestSSH(t *testing.T) {
		assert.NoError(t, err)
		})

		tGo(t, func() {
		// When the agent connects, the workspace was started, and we should
		// have access to the shell.
		_ = agenttest.New(t, client.URL, authToken)
		coderdtest.NewWorkspaceAgentWaiter(t, client, workspace.ID).Wait()
		})
		// When the agent connects, the workspace was started, and we should
		// have access to the shell.
		_ = agenttest.New(t, client.URL, authToken)
Copy link Member mafredriFeb 22, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Could consider a`defer a.Close()` here too, to speed up the agents tear-down, not sure whether or not it would help with the issue being fixed here though. Copy link ContributorAuthor spikecurtisFeb 22, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I think it will amount to the same thing. There is already a`t.Cleanup()` that closes it, which will run after the later`defer`s in this function.

		conn, channels, requests, err := ssh.NewClientConn(&stdioConn{
		Reader: proxyCommandStdoutR,
Expand Down