Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: pad golden file timestamps#12256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Emyrk wants to merge2 commits intomainfromstevenmasley/golden-spacing

Conversation

Emyrk
Copy link
Member

Making the replacement the same length keeps table formats the same in a golden file.

@EmyrkEmyrk requested a review frommafredriFebruary 21, 2024 21:59
@EmyrkEmyrk changed the titlechore: padding on golden file timestampschore: pad golden file timestampsFeb 21, 2024
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh, didn't realize we'd mess with the JSON as well, maybe not worth fixing the golden file in this case but I'll leave it up to you. Thanks for trying it out anyway!

@Emyrk
Copy link
MemberAuthor

@matifali The json is affected, but it's not terrible?

matifali reacted with eyes emoji

Making the replacement the same length keeps table formats the samein a golden file.
@EmyrkEmyrkforce-pushed thestevenmasley/golden-spacing branch from48a100c toff4d5c1CompareFebruary 23, 2024 15:29
@Emyrk
Copy link
MemberAuthor

I am going to close this since most of our golden files are json.

If the padding becomes a visual issue, we can readdress.

@EmyrkEmyrk closed thisFeb 23, 2024
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 23, 2024
@github-actionsgithub-actionsbot deleted the stevenmasley/golden-spacing branchAugust 24, 2024 00:05
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@EmyrkEmyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Emyrk@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp