Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: support custom validation errors for number-typed parameters#12224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 9 commits intomainfrom12192-number-error
Feb 20, 2024

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedFeb 20, 2024•
edited
Loading

Fixes:#12192

This PR modifiescoderd,site, andCLI to support custom validation errors. Fortunately, this PR is relatively small.

Template preview:

data "coder_parameter" "foobar_1" {  name         = "foobar_1"  display_name = "Foobar 1"  type         = "number"  description  = "Let's set the foobar."  default      = "3"  mutable      = true  validation {    min   = 3    max   = 5    error = "This is custom error {min}, {max}, {value}."  }}

@mtojekmtojek self-assigned thisFeb 20, 2024
@mtojekmtojek marked this pull request as ready for reviewFebruary 20, 2024 14:01
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just a nit comment. 👍 for the tests

Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍

@mtojekmtojek merged commit57bf997 intomainFeb 20, 2024
@mtojekmtojek deleted the 12192-number-error branchFebruary 20, 2024 15:32
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 20, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: support custom error message for number-typed coder parameters
3 participants
@mtojek@BrunoQuaresma@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp