- Notifications
You must be signed in to change notification settings - Fork928
feat: Add user menu on users table#1222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -40,17 +40,21 @@ export interface TableProps<T> { | ||
| * Optional empty state UI when the data is empty | ||
| */ | ||
| emptyState?: React.ReactElement | ||
| /** | ||
| * Optional element to render row actions like delete, update, etc | ||
| */ | ||
| rowMenu?: (data: T) => React.ReactElement | ||
| } | ||
| export const Table = <T,>({ columns, data, emptyState, title, rowMenu }: TableProps<T>): React.ReactElement => { | ||
| const columnNames = columns.map(({ name }) => name) | ||
| const body = renderTableBody(data, columns, emptyState, rowMenu) | ||
| return ( | ||
| <MuiTable> | ||
| <TableHead> | ||
| {title && <TableTitle title={title} />} | ||
| <TableHeaders columns={columnNames}hasMenu={!!rowMenu}/> | ||
| </TableHead> | ||
| {body} | ||
| </MuiTable> | ||
| @@ -60,7 +64,12 @@ export const Table = <T,>({ columns, data, emptyState, title }: TableProps<T>): | ||
| /** | ||
| * Helper function to render the table data, falling back to an empty state if available | ||
| */ | ||
| const renderTableBody = <T,>( | ||
| data: T[], | ||
| columns: Column<T>[], | ||
| emptyState?: React.ReactElement, | ||
| rowMenu?: (data: T) => React.ReactElement, | ||
| ) => { | ||
| if (data.length > 0) { | ||
| const rows = data.map((item: T, index) => { | ||
| const cells = columns.map((column) => { | ||
| @@ -70,7 +79,12 @@ const renderTableBody = <T,>(data: T[], columns: Column<T>[], emptyState?: React | ||
| return <TableCell key={String(column.key)}>{String(item[column.key]).toString()}</TableCell> | ||
| } | ||
| }) | ||
| return ( | ||
| <TableRow key={index}> | ||
| {cells} | ||
| {rowMenu && <TableCell>{rowMenu(item)}</TableCell>} | ||
| </TableRow> | ||
| ) | ||
BrunoQuaresma marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| }) | ||
| return <TableBody>{rows}</TableBody> | ||
| } else { | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -5,9 +5,10 @@ import React from "react" | ||
| export interface TableHeadersProps { | ||
| columns: string[] | ||
| hasMenu?: boolean | ||
| } | ||
| export const TableHeaders: React.FC<TableHeadersProps> = ({ columns, hasMenu }) => { | ||
| const styles = useStyles() | ||
| return ( | ||
| <TableRow className={styles.root}> | ||
| @@ -16,6 +17,8 @@ export const TableHeaders: React.FC<TableHeadersProps> = ({ columns }) => { | ||
| {c} | ||
| </TableCell> | ||
| ))} | ||
| {/* 1% is a trick to make the table cell width fit the content */} | ||
| {hasMenu && <TableCell width="1%" />} | ||
Contributor
| ||
| </TableRow> | ||
| ) | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import{ComponentMeta,Story}from"@storybook/react" | ||
| importReactfrom"react" | ||
| import{TableRowMenu,TableRowMenuProps}from"./TableRowMenu" | ||
| exportdefault{ | ||
| title:"components/TableRowMenu", | ||
| component:TableRowMenu, | ||
| }asComponentMeta<typeofTableRowMenu> | ||
| typeDataType={ | ||
| id:string | ||
| } | ||
| constTemplate:Story<TableRowMenuProps<DataType>>=(args)=><TableRowMenu{...args}/> | ||
| exportconstExample=Template.bind({}) | ||
| Example.args={ | ||
| data:{id:"123"}, | ||
| menuItems:[ | ||
| {label:"Suspend",onClick:(data)=>alert(data.id)}, | ||
| {label:"Update",onClick:(data)=>alert(data.id)}, | ||
| {label:"Delete",onClick:(data)=>alert(data.id)}, | ||
| ], | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import IconButton from "@material-ui/core/IconButton" | ||
| import Menu, { MenuProps } from "@material-ui/core/Menu" | ||
| import MenuItem from "@material-ui/core/MenuItem" | ||
| import MoreVertIcon from "@material-ui/icons/MoreVert" | ||
| import React from "react" | ||
| export interface TableRowMenuProps<TData> { | ||
| data: TData | ||
| menuItems: Array<{ | ||
| label: string | ||
| onClick: (data: TData) => void | ||
| }> | ||
| } | ||
| export const TableRowMenu = <T,>({ data, menuItems }: TableRowMenuProps<T>): JSX.Element => { | ||
| const [anchorEl, setAnchorEl] = React.useState<MenuProps["anchorEl"]>(null) | ||
| const handleClick = (event: React.MouseEvent) => { | ||
| setAnchorEl(event.currentTarget) | ||
| } | ||
| const handleClose = () => { | ||
| setAnchorEl(null) | ||
| } | ||
| return ( | ||
| <> | ||
| <IconButton size="small" aria-label="more" aria-controls="long-menu" aria-haspopup="true" onClick={handleClick}> | ||
| <MoreVertIcon /> | ||
| </IconButton> | ||
| <Menu id="simple-menu" anchorEl={anchorEl} keepMounted open={Boolean(anchorEl)} onClose={handleClose}> | ||
| {menuItems.map((item) => ( | ||
| <MenuItem | ||
| key={item.label} | ||
| onClick={() => { | ||
| handleClose() | ||
| item.onClick(data) | ||
| }} | ||
| > | ||
| {item.label} | ||
| </MenuItem> | ||
| ))} | ||
| </Menu> | ||
| </> | ||
| ) | ||
| } |