- Notifications
You must be signed in to change notification settings - Fork928
fix(site): add tests and improve accessibility for useClickable#12218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
* announce the row's data as part of a larger table) | ||
* | ||
* It might not make sense to test this hook until the underlying design | ||
* problems are fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
WDYT about moving this into a ticket as well as a note in the milestone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, just for documentation/visibility, I think that'd be best.
Wondering if we could use an accessibility milestone, too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This seems clean to me!
Uh oh!
There was an error while loading.Please reload this page.
Part 3 for thehooks milestone
Changes made
useClickable
to be much more compliant with WCAG guidelinesuseClickable
useClickableTableRow
(see notes)Notes