Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(helm)!: remove prometheus-http port declaration from coderd service spec#12214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 5 commits intomainfromcj/rm-prom-svc
Feb 20, 2024

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedFeb 19, 2024•
edited
Loading

This PR removes theprometheus-http port entirely from the coder service specification (originally added in#10448). It also removes the Helm valuecoder.service.prometheusNodePort.

Rationale: some cloud providers will helpfully expose all ports on aLoadBalancer service for you. The net effect of this is that settingCODER_PROMETHEUS_ENABLE will end up exposing port 2112 on your coderd service to the internet, which is likely undesired behaviour.

cc@bpmct for visibility, this will need to be called out in release notes

Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is probably a breaking change. I don't think we should provide an alternative though, customers can create their own service (if they really need a service) or they can use annotations/labels on the pod which we already support

johnstcn reacted with thumbs up emoji
@johnstcn
Copy link
MemberAuthor

This is probably a breaking change.

/s/probably/definitely

@johnstcnjohnstcn marked this pull request as ready for reviewFebruary 19, 2024 17:35
@johnstcnjohnstcn changed the titlefix!(helm): remove prometheus-http port declaration from coderd service specfix(helm)!: remove prometheus-http port declaration from coderd service specFeb 19, 2024
@github-actionsgithub-actionsbot added the release/breakingThis label is applied to PRs to detect breaking changes as part of the release process labelFeb 19, 2024
@johnstcnjohnstcn added the securityArea: security labelFeb 19, 2024
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@johnstcnjohnstcn merged commitc62a8b0 intomainFeb 20, 2024
@johnstcnjohnstcn deleted the cj/rm-prom-svc branchFebruary 20, 2024 11:36
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 20, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@mtojekmtojekmtojek approved these changes

@coadlercoadlerAwaiting requested review from coadler

@spikecurtisspikecurtisAwaiting requested review from spikecurtis

Assignees

@johnstcnjohnstcn

Labels
release/breakingThis label is applied to PRs to detect breaking changes as part of the release processsecurityArea: security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@johnstcn@spikecurtis@deansheather@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp