Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(agent): add script data dir for binaries and files#12205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 11 commits intomainfrommafredri/feat-agent-script-paths
Feb 20, 2024

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedFeb 19, 2024
edited
Loading

The agent is extended with a--script-data-dir flag, defaulting to the
OS temp dir. This dir is used for storingcoder-script-data/bin and
coder-script/[script uuid]. The former is a place for all scripts to
place executable binaries that will be available by other scripts, SSH
sessions, etc. The latter is a place for the script to store files.

Since we default to OS temp dir, files are ephemeral by default. In the
future, we may consider adding new env vars or changing the default
storage location. Workspace startup speed could potentially benefit from
scripts being able to skip steps that require downloading software. We
may also extend this with more env variables (e.g. persistent storage in
HOME).

Fixes#11131

This can be feature detected by checking if$CODER_SCRIPT_DATA_DIR and/or$CODER_SCRIPT_BIN_DIR is set.

@mafredrimafredri self-assigned thisFeb 19, 2024
@mafredrimafredriforce-pushed themafredri/feat-agent-script-paths branch frome804a03 to02daaddCompareFebruary 19, 2024 11:41
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nothing blocking!

@mafredrimafredriforce-pushed themafredri/feat-agent-script-paths branch from7bd2ed0 tof09a284CompareFebruary 19, 2024 13:17
@mafredrimafredriforce-pushed themafredri/refactor-agentssh-config branch 2 times, most recently fromffae4ad todd66b45CompareFebruary 19, 2024 14:02
Base automatically changed frommafredri/refactor-agentssh-config tomainFebruary 19, 2024 14:30
The agent is extended with a `--script-data-dir` flag, defaulting to theOS temp dir. This dir is used for storing `coder-script/bin` and`coder-script/[script uuid]`. The former is a place for all scripts toplace executable binaries that will be available by other scripts, SSHsessions, etc. The latter is a place for the script to store files.Since we default to OS temp dir, files are ephemeral by default. In thefuture, we may consider adding new env vars or changing the defaultstorage location. Workspace startup speed could potentially benefit fromscripts being able to skip steps that require downloading software. Wemay also extend this with more env variables (e.g. persistent storage inHOME).Fixes#11131
@mafredrimafredriforce-pushed themafredri/feat-agent-script-paths branch fromf09a284 to0f6f254CompareFebruary 19, 2024 14:34
@mafredrimafredriforce-pushed themafredri/feat-agent-script-paths branch from3b682e1 tod894786CompareFebruary 19, 2024 17:03
@mafredrimafredriforce-pushed themafredri/feat-agent-script-paths branch 4 times, most recently frome5858f7 to89b8297CompareFebruary 20, 2024 10:28
@mafredrimafredriforce-pushed themafredri/feat-agent-script-paths branch from19d9582 to7dbfc2bCompareFebruary 20, 2024 11:08
@mafredrimafredri merged commitb1c0b39 intomainFeb 20, 2024
@mafredrimafredri deleted the mafredri/feat-agent-script-paths branchFebruary 20, 2024 11:26
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 20, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@mtojekmtojekmtojek approved these changes

@bpmctbpmctAwaiting requested review from bpmct

@matifalimatifaliAwaiting requested review from matifali

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow the coder agent to tell modules where they can place data, binaries, etc
3 participants
@mafredri@johnstcn@mtojek

[8]ページ先頭

©2009-2025 Movatter.jp