- Notifications
You must be signed in to change notification settings - Fork1k
feat: add oauth2 token exchange#12196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
Emyrk approved these changesFeb 20, 2024
Comment on lines +1236 to +1240
| // The user ID is on the API key so that has to be fetched. | ||
| key, err := q.db.GetAPIKeyByID(ctx, token.APIKeyID) | ||
| if err != nil { | ||
| return database.OAuth2ProviderAppToken{}, err | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That is annoying 😢
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Might have no match, and a -1 will panic.
This will be used as an ID that we can prefix into the secretsthemselves. This is so we can salt the hashed secrets.The token query is for implementing the refresh flow.
0204adb to70cedd6Compare7fd123e toda447c2CompareWithout this I think the tests would fail since they are not adding aprefix and there is no default.
da447c2 toe517d8eCompareSign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Re-opened since the original got closed by stale bot and will not let me re-open after force-pushing!
Rename token hashed_secret to refresh_hashand later are new since that PR was last reviewed. The main thing is that a secret prefix was added.#11778