- Notifications
You must be signed in to change notification settings - Fork928
fix(examples): remove dead code comment#12194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix(examples): remove dead code comment#12194
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This stack of pull requests is managed by Graphite.Learn more about stacking. |
| @@ -242,8 +242,7 @@ resource "kubernetes_deployment" "main" { | |||
| } | |||
| spec { | |||
| # replicas = data.coder_workspace.me.start_count | |||
| replicas=1 | |||
| replicas=data.coder_workspace.me.start_count | |||
| selector { | |||
| match_labels={ | |||
| "app.kubernetes.io/name"="coder-workspace" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Also, FWIW, I was using this on a GKE autopilot cluster which doesn't support overprovisioning and my pods only ever got `250m` CPU. I think this should probably be configurable, rather than the only option.
See this comment inline onGraphite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If we are using the count on deployment and the deployment gets scaled to 0. Does the count value on the pod matter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh I see, I'm dumb. Though thinking about it now, I wonder if it would be better to just scale up and down the replicas rather than delete and recreate the deployment each time. I'll just remove the dead code comment for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
My issue still stands about the overprovisioning issue, though. Would like your thoughts
| @@ -242,8 +242,7 @@ resource "kubernetes_deployment" "main" { | |||
| } | |||
| spec { | |||
| # replicas = data.coder_workspace.me.start_count | |||
| replicas=1 | |||
| replicas=data.coder_workspace.me.start_count | |||
| selector { | |||
| match_labels={ | |||
| "app.kubernetes.io/name"="coder-workspace" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If we are using the count on deployment and the deployment gets scaled to 0. Does the count value on the pod matter?
5526932 to78e1c15Compare
No description provided.