- Notifications
You must be signed in to change notification settings - Fork928
fix(enterprise/coderd): check provisionerd API version on connection#12191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
mafredri approved these changesFeb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Moves package coderd/util/apiversion to apiversion to avoid import cycles.
I'm not opposed to the change but I saw nothing that would've cause an import cycle without the restructuring.
Uh oh!
There was an error while loading.Please reload this page.
aslilac approved these changesFeb 16, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Extracted from#12021
Moves package
coderd/util/apiversiontoapiversionto avoid import cycles.Adds a version check when a provisioner daemon attempts to connect to coderd.
We were not doing this before.
We assume that the API version is "1.0" if no version is specified.
Adds a test that a missing
versionparameter is treated as API version 1.0.